On Mon, May 14, 2012 at 11:51:38AM +0800, Shawn Guo wrote: > From what I see, it's reasonable. Then the immediate question I have > is, should we remove "struct anatop *adata" from anatop_read_reg and > anatop_write_reg completely? Given the way these things tend to go it's probably guaranteeing that your next round of SoCs will have two register compatible anatop blocks :)