mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: grant.likely@secretlab.ca, linux-kernel@vger.kernel.org,
	giancarlo.asnaghi@st.com, alan@linux.intel.com,
	sameo@linux.intel.com, linus.walleij@stericsson.com
Subject: Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block
Date: Mon, 14 May 2012 10:47:37 +0100	[thread overview]
Message-ID: <20120514094737.GB2189@sirena.org.uk> (raw)
In-Reply-To: <20120514072534.GA29871@mail.gnudd.com>

On Mon, May 14, 2012 at 09:25:34AM +0200, Alessandro Rubini wrote:

> >> +	/* 384 was used in previous code: be compatible for other drivers */
> >> +	err = irq_alloc_descs(-1, 384, GSTA_NR_GPIO, NUMA_NO_NODE);

> > Where does the number 384 come from?  It looks like the driver only
> > needs to allocate a range of irqs and that it doesn't actually matter
> > what the real numbers are.  Can 0 be used instead?

> The problem is that there are a number of drivers already working (but
> not ready to be upstreamed), and we'd better continue using them.  So,
> the mmc driver is requesting a specific interrupt number.  The code is
> GPL (published on sourceforge) and I'd better remain compatible.

> I'm not completely clear (yet) about how to get the right interrupt
> number in those other drivers, but I'm willing to remove the constraint
> as they are cleaned up and submitted.

Use platform data for both this driver and the other drivers (or device
tree if you're doing that).  This will hard code the magic numbers in
the board files, not in the driver.

  reply	other threads:[~2012-05-14  9:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12  8:48 [PATCH V3 0/2] MFD and GPIO for STA2X11 Alessandro Rubini
2012-04-12  8:48 ` [PATCH V3 1/2] mfd: Add driver for STA2X11 MFD block Alessandro Rubini
2012-04-16 18:05   ` Samuel Ortiz
2012-04-16 18:11   ` Alessandro Rubini
2012-05-09 13:37   ` Samuel Ortiz
2012-04-12  8:48 ` [PATCH V3 2/2] gpio: add STA2X11 GPIO block Alessandro Rubini
2012-04-12 15:05   ` Linus Walleij
2012-04-13 11:44   ` Alessandro Rubini
2012-04-13 12:32     ` Linus Walleij
2012-04-13 16:34   ` Linus Walleij
2012-05-09 13:40   ` Samuel Ortiz
2012-05-11 23:34   ` Grant Likely
2012-05-14  7:25   ` Alessandro Rubini
2012-05-14  9:47     ` Mark Brown [this message]
2012-05-14  9:51     ` Alessandro Rubini
2012-05-14  9:58       ` Mark Brown
2012-05-14 10:06       ` Alessandro Rubini
2012-05-14 10:08         ` Mark Brown
2012-05-18  9:10     ` Samuel Ortiz
2012-04-16 17:55 ` [PATCH V3 0/2] MFD and GPIO for STA2X11 Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514094737.GB2189@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alan@linux.intel.com \
    --cc=giancarlo.asnaghi@st.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rubini@gnudd.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®