From: Greg KH <gregkh@linuxfoundation.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: broonie@opensource.wolfsonmicro.com, thomas.abraham@linaro.org,
grant.likely@secretlab.ca, sameo@linux.intel.com,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
jonghwa3.lee@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Extcon: MAX8997: Add support irq domain for MAX8997 muic
Date: Mon, 14 May 2012 09:13:19 -0700 [thread overview]
Message-ID: <20120514161319.GA21735@kroah.com> (raw)
In-Reply-To: <1336698621-10907-1-git-send-email-cw00.choi@samsung.com>
On Fri, May 11, 2012 at 10:10:21AM +0900, Chanwoo Choi wrote:
> This patch add support irq domain for Maxim MAX8997 muic
> instead of irq_base in platform data and max8997 driver
> private data are instead. It is tested on TRATS board.
>
> v2
> - Fix typo when free_irq() in max8997_muic_probe()
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/extcon/extcon-max8997.c | 28 +++++++++++++++++-----------
> 1 files changed, 17 insertions(+), 11 deletions(-)
This patch breaks the build on my system:
CC [M] drivers/extcon/extcon-max8997.o
drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_probe’:
drivers/extcon/extcon-max8997.c:456:3: error: implicit declaration of function ‘irq_create_mapping’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
So I can't accept these two patches, sorry. Please fix this up.
greg k-h
prev parent reply other threads:[~2012-05-14 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 1:10 Chanwoo Choi
2012-05-14 16:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514161319.GA21735@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome