mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: manjunatha_halli@ti.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Manjunatha Halli <x0130808@ti.com>
Subject: Re: [PATCH V5 2/5] New control class and features for FM RX
Date: Mon, 14 May 2012 21:44:36 +0200	[thread overview]
Message-ID: <201205142144.36771.hverkuil@xs4all.nl> (raw)
In-Reply-To: <1337023469-24990-3-git-send-email-manjunatha_halli@ti.com>

Hi Manjunatha,

I wish I could ack this series, but there is one thing that really needs
to change:

On Mon May 14 2012 21:24:26 manjunatha_halli@ti.com wrote:
> @@ -1843,13 +1857,22 @@ struct v4l2_frequency {
>  	__u32		      reserved[8];
>  };
>  
> +
> +#define FM_BAND_TYPE_DEFAULT	0	/* All Bands 65.8 MHz till 108 Mhz
> +					   or 162.55 MHz if weather band */
> +#define FM_BAND_TYPE_EUROPE_US	1	/* 87.5 Mhz - 108 MHz*/
> +#define FM_BAND_TYPE_JAPAN	2	/* 76 MHz - 90 MHz*/
> +#define FM_BAND_TYPE_RUSSIAN	3	/* 65.8 MHz - 74 MHz*/
> +#define FM_BAND_TYPE_WEATHER	4	/* 162.4 MHz - 162.55 MHz*/

This needs a V4L2_ prefix. And in my opinion the _TYPE part can be dropped.

So it becomes:

#define V4L2_FM_BAND_DEFAULT	0
#define V4L2_FM_BAND_EUROPE_US	1	/* 87.5 Mhz - 108 MHz */
#define V4L2_FM_BAND_JAPAN	2	/* 76 MHz - 90 MHz */
#define V4L2_FM_BAND_RUSSIAN	3	/* 65.8 MHz - 74 MHz */
#define V4L2_FM_BAND_WEATHER	4	/* 162.4 MHz - 162.55 MHz */

BTW, also put a space before '*/'.

If you can make this change quickly (i.e. today) and post the fixed version
(don't forget to update the documentation as well!) then I'll ack it and
there is a change you can get it merged for 3.5.

Regards,

	Hans

> +
>  struct v4l2_hw_freq_seek {
>  	__u32		      tuner;
>  	enum v4l2_tuner_type  type;
>  	__u32		      seek_upward;
>  	__u32		      wrap_around;
>  	__u32		      spacing;
> -	__u32		      reserved[7];
> +	__u32		      band;
> +	__u32		      reserved[6];
>  };
>  
>  /*
> 

  reply	other threads:[~2012-05-14 19:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 19:24 [PATCH V5 0/5] [Media] Radio: Fixes and New features for FM manjunatha_halli
2012-05-14 19:24 ` [PATCH V5 1/5] WL128x: Add support for FM TX RDS manjunatha_halli
2012-05-14 19:24 ` [PATCH V5 2/5] New control class and features for FM RX manjunatha_halli
2012-05-14 19:44   ` Hans Verkuil [this message]
2012-05-14 19:24 ` [PATCH V5 3/5] Add new CID for FM TX RDS Alternate Frequency manjunatha_halli
2012-05-14 19:24 ` [PATCH V5 4/5] Media: Update docs for V4L2 FM new features manjunatha_halli
2012-05-14 19:47   ` Hans Verkuil
2012-05-14 19:24 ` [PATCH V5 5/5] WL12xx: Add support for " manjunatha_halli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205142144.36771.hverkuil@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=manjunatha_halli@ti.com \
    --cc=x0130808@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®