mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hiroshi Doyu <hdoyu@nvidia.com>
To: "swarren@wwwdotorg.org" <swarren@wwwdotorg.org>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"joerg.roedel@amd.com" <joerg.roedel@amd.com>,
	"thierry.reding@avionic-design.de"
	<thierry.reding@avionic-design.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org" 
	<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] iommu/tegra: smmu: Simplify allocation at once
Date: Tue, 15 May 2012 10:26:49 +0200	[thread overview]
Message-ID: <20120515.112649.411607744957826949.hdoyu@nvidia.com> (raw)
In-Reply-To: <4FB19677.4040702@wwwdotorg.org>

Stephen Warren <swarren@wwwdotorg.org> wrote @ Tue, 15 May 2012 01:34:15 +0200:

> On 05/14/2012 01:16 PM, Hiroshi DOYU wrote:
> > To simplify the code, alloc necessary data at once.
> > 
> > Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>
> > ---
> > This patch requires:
> > 
> >     [PATCH 1/2] iommu/tegra: smmu: Add device tree support for SMMU
> >         http://marc.info/?l=linux-tegra&m=133663641107327&w=2
> > 
> > Also the above patch requires:
> > 
> >     [PATCH 1/1] dt: Add general DMA window parser
> >         http://marc.info/?l=linux-tegra&m=133671302703840&w=2
> 
> I know I've been harping on about dependencies, but you typically only
> need to mention them if the dependencies are not already checked into
> the branch you expect this patch to be checked into.
> 
> > -	smmu = devm_kzalloc(dev, sizeof(*smmu), GFP_KERNEL);
> > +	if (of_property_read_u32(dev->of_node, "nvidia,#asids", &asids))
> > +		return -ENODEV;
> 
> I believe you need to change the asids variable from int to u32 to avoid
> a warning here.

There's no warning but it's allowed because of "-Wno-pointer-sign". It
seems that this flag has been used for long in kernel, and there are
many places. Is this conversion allowed because it's expeced that the
author should know the range of value, or any other reason?

*1:
-Wno-pointer-sign
    Don't warn for pointer argument passing or assignment with
    different signedness. Only useful in the negative form since this
    warning is enabled by default. This option is only supported for C
    and Objective-C.

  parent reply	other threads:[~2012-05-15  8:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 19:16 Hiroshi DOYU
2012-05-14 19:16 ` [PATCH 2/2] iommu/tegra: smmu: Remove unnecessary cleanups with devm_*() Hiroshi DOYU
2012-05-14 23:34 ` [PATCH 1/2] iommu/tegra: smmu: Simplify allocation at once Stephen Warren
2012-05-15  8:06   ` Hiroshi Doyu
2012-05-15  8:12   ` [v2 " Hiroshi DOYU
2012-05-15  8:12     ` [v2 2/2] iommu/tegra: smmu: Remove unnecessary cleanups with devm_*() Hiroshi DOYU
2012-05-15  8:26   ` Hiroshi Doyu [this message]
2012-05-15 16:09     ` [PATCH 1/2] iommu/tegra: smmu: Simplify allocation at once Stephen Warren
2012-05-15 18:47       ` Hiroshi Doyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515.112649.411607744957826949.hdoyu@nvidia.com \
    --to=hdoyu@nvidia.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®