Re: [PATCH] x86: Fix boot on Twinhead H12Y

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Tue, 15 May 2012 09:52:07 -0700
Joe Perches <joe@perches.com> wrote:

> On Tue, 2012-05-15 at 18:44 +0100, Alan Cox wrote:
> > Despite lots of investigation into why this is needed we don't know or have
> > an elegant cure. The only answer found on this laptop is to mark a problem
> > region as used so that Linux doesn't put anything there.
> 
> trivia:
> 
> > diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
> []
> > @@ -519,3 +519,22 @@ static void sb600_disable_hpet_bar(struct pci_dev *dev)
> []
> > +static void __devinit twinhead_reserve_killing_zone(struct pci_dev *dev)
> > +{
> > +        if (dev->subsystem_vendor == 0x14FF && dev->subsystem_device ==
> > +                                        0xA003) {
> 
> Doesn't this look ugly to you?
> Doesn't 
> 
> 	if (dev->subsystem_vendor == 0x14FF &&
> 	    dev->subsystem_device == 0xA003) {
> 
> at least read more easily?

Well I'd further indent the second half so your eyes drop across reading
left to right, but to be honest I'd have put it on one line but for the
80columnists.

If thats the only problem anyone has with it then I'm fine in adding a
tab or two.