From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: ddaney.cavm@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, david.daney@cavium.com
Subject: Re: [PATCH] netdev/phy: Make get_phy_id() static and quit EXPORTing it.
Date: Wed, 16 May 2012 00:59:57 -0400 (EDT) [thread overview]
Message-ID: <20120516.005957.867101981297584239.davem@davemloft.net> (raw)
In-Reply-To: <20120515213208.GD17760@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Tue, 15 May 2012 17:32:08 -0400
> [[PATCH] netdev/phy: Make get_phy_id() static and quit EXPORTing it.] On 15/05/2012 (Tue 13:46) David Daney wrote:
>
>> From: David Daney <david.daney@cavium.com>
>>
>> This function is only referenced from within phy_device.c, so there is
>> no reason to export it. In fact, we can make it static.
>
> I did a bit of data mining to remind myself why it was exported. Back
> in a01b3d766c (v2.6.26) gianfar_mii was using it. That then got merged
> into fsl_pq_mdio.c and gianfar_mii was deleted. Then finally in commit
> 28d8ea2d568 (v3.2) the one instance of code that was using it got
> removed. So, I think this should be OK (but for net-next, though).
>
> Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied.
prev parent reply other threads:[~2012-05-16 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 20:46 David Daney
2012-05-15 21:32 ` Paul Gortmaker
2012-05-16 4:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516.005957.867101981297584239.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®