Re: [PATCH] driver: char: bfin_crc: CRC hardware accelerator driver for BF60x family processors.

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, May 16, 2012 at 04:26:07PM +0800, sonic.zhang@analog.com wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> The CRC peripheral is a hardware block used to compute the CRC of the block
> of data. This is based on a CRC32 engine which computes the CRC value of 32b
> data words presented to it. For data words of < 32b in size, it is the
> responsibility of the application to pack the data into 32b data units.
> 
> This driver defines data strcture crc_info and 4 IOCTL interfaces for applciations.
> 1) CRC Memory Scan
> 2) CRC Memory Transfer
> 3) CRC Data Verify
> 4) CRC Data Fill
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
>  drivers/char/Kconfig    |    8 +
>  drivers/char/Makefile   |    1 +
>  drivers/char/bfin_crc.c |  537 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 546 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/char/bfin_crc.c

Why is this a char driver, and not a crypto driver, using the existing
crypto userspace api for things like this?

> diff --git a/drivers/char/bfin_crc.c b/drivers/char/bfin_crc.c
> new file mode 100644
> index 0000000..3f7d1d8
> --- /dev/null
> +++ b/drivers/char/bfin_crc.c
> @@ -0,0 +1,537 @@
> +/*
> + * Blackfin On-Chip hardware CRC Driver
> + *
> + * Copyright 2011 Analog Devices Inc.
> + *
> + * Licensed under the GPL-2 or later.

Do you really mean "or later"?  It's fine if you do, just checking.

thanks,

greg k-h