From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: mjg@redhat.com, tianyu.lan@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: fix breakage on systems without ACPI
Date: Wed, 16 May 2012 05:21:53 -0700 [thread overview]
Message-ID: <20120516122153.GA31684@kroah.com> (raw)
In-Reply-To: <1337170275-23859-1-git-send-email-levinsasha928@gmail.com>
On Wed, May 16, 2012 at 02:11:15PM +0200, Sasha Levin wrote:
> Commit da0af6e ("usb: Bind devices to ACPI devices when possible") really
> tries to force-bind devices even when impossible, unlike what it says in
> the subject.
>
> CONFIG_ACPI is not an indication that ACPI tables are actually present, nor
> is an indication that any USB relevant information is present in them. There
> is no reason to fail the creation of a USB bus if it can't bind it to
> ACPI device during initialization.
>
> On systems with CONFIG_ACPI set but without ACPI tables it would cause a
> boot panic.
Nice catch, sorry about that, I'll go queue this up.
greg k-h
next prev parent reply other threads:[~2012-05-16 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 12:11 Sasha Levin
2012-05-16 12:21 ` Greg KH [this message]
2012-05-16 14:05 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516122153.GA31684@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome