Re: [PATCH 0/4] KVM: Enable EPT access bit feature

[Takuya Yoshikawa <takuya.yoshikawa@gmail.com>]

On Wed, 16 May 2012 12:21:53 +0300
Avi Kivity <avi@redhat.com> wrote:

> On 05/16/2012 04:04 AM, Xudong Hao wrote:
> > EPT A/D bits enable VMMs to efficiently implement memory management and page classification algorithms to optimize VM memory operations such as de-fragmentation, paging, live-migration, and check-pointing.
> >
> > The series of patches enable the EPT access bit in KVM.
> >
> > PATCH 1: Add EPT A/D bits definition.
> > PATCH 2: Add kernel parameter to control EPT A/D bits support, the feature is on by default.
> > PATCH 3: Enable EPT A/D bits if supported by turning on relevant bit in EPTP.
> > PATCH 4: Enabling Access bit when doing memory swapping.
> >
> 
> Minor comment on patch 2, but otherwise looks good.

Except for being white space damaged and based on old kvm.git?

BTW, we can use this for dirty logging as you suggested.

Although we need to traverse each spte from rmap and sync with dirty
bitmap, I think it will work well by using with range based GET_DIRTY_LOG
to restrict the cost for one call.

Thanks,
	Takuya