Re: [PATCH v24b] RAS: Add a tracepoint for reporting memory controller events

[Borislav Petkov <bp@amd64.org>]

On Fri, May 18, 2012 at 11:31:46AM -0300, Mauro Carvalho Chehab wrote:
> Ok, but you won't use trace_sched_switch() as a memory tracepoint, as
> they represent different things.
> 
> Memory errors are different than CPU errors. So, their tracepoints
> will be different.

WTF? A tracepoint is a tracepoint.

> > Right, and this is why I'm asking you to have the following tracepoint proto:
> > 
> > +       TP_PROTO(const unsigned int err_type,
> > +                const unsigned int mc_index,
> > +                const char *error_msg,
> > +                const char *label,
> > +                const char *location,
> > +                const char *detail)
> > 
> > where detail contains all the crap one driver adds for technical people
> > to pinpoint where the error is.
> > 
> > And not have _TWO_ detail arguments!
> 
> And what I'm saying is that this should be, instead:
> 
> + TP_PROTO(const unsigned int err_type,
> +          const unsigned int mc_index,
> +          const char *error_msg,
> +          const char *label,
> +          int layer0,
> +          int layer1,
> +          int layer2,
> +          unsigned long pfn,
> +          unsigned long offset,
> +          unsigned long grain,
> +          unsigned long syndrome,
> +          const char *driver_detail),
> 
> So, having just one detail argument, filled by the driver, and not
> folding "location" and core "details" into strings, but keeping as they
> are.

And this way you're enforcing an interface that all drivers will have
to adhere to. What if "grain" doesn't mean a thing for a driver, or
"syndrome" or whatever? What if some other entity wants to use that
tracepoint?

See what I'm sayin?

Having

       TP_PROTO(const unsigned int err_type,
                const unsigned int mc_index,
                const char *error_msg,
                const char *label,
                const char *location,
                const char *detail)

is a bit more generic and userspace can parse it however it likes.

Actually, I'd slim this up even more:

       TP_PROTO(const unsigned int mc_index,
                const char *error_msg,
                const char *label,
                const char *location,
                const char *detail)

and have error_msg contain the "Corrected/Uncorrected/Fatal" things
and this way you can drop all the ternary operators in the tracepoint
definition.

> > Btw, the output looks like this here:
> > 
> >            <...>-2723  [001] .N..    89.107045: mc_event: Corrected error: on memory stick "unknown memory" (mc:0 csrow:3 channel:1 page:0x5bac7 offset:0x388 grain:0 syndrome:0xfc5b driver:amd64_edac)
> > 
> > Come to think of it, the "driver:amd64_edac" is not really needed
> > because on every single system there's only one EDAC driver running and
> > I don't think the fact that we're telling in the tracepoint who detected
> > the error is meaningfull information.
> > 
> > Which means, you can remove the EDAC_MOD_STR argument you're passing to
> > edac_mc_handle_error() and have one less argument.
> 
> That's what I said you, but you didn't seem to agree, as I understood that
> you've required to keep "amd64_edac"  at the trace, due to:
> 	http://markmail.org/message/nr3ooep7gc7mhgdl.
> 
> If you're ok, I'll remove EDAC_MOD_STR argument from the amd64_edac calls
> on a separate patch (with can be merged latter with the patch that converted
> amd64_edac to the new function calls).

Ok.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551