mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: mdharm-usb@one-eyed-alien.net, linux-usb@vger.kernel.org,
	usb-storage@lists.one-eyed-alien.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1]USB:storage:fixed space at the start of a line issues.
Date: Fri, 18 May 2012 12:24:45 -0700	[thread overview]
Message-ID: <20120518192445.GA4781@kroah.com> (raw)
In-Reply-To: <1337368715-3859-1-git-send-email-ahiliation@yahoo.co.in>

On Sat, May 19, 2012 at 12:48:35AM +0530, Jeffrin Jose wrote:
> Fixed space at the start of a line issues found
> by checkpatch.pl tool in drivers/usb/storage/usual-tables.c
> 
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>

Your subject is better, but now you forgot the spaces after the ':'
characters, what happened to them?

> ---
>  drivers/usb/storage/usual-tables.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> index b969279..f2301ee 100644
> --- a/drivers/usb/storage/usual-tables.c
> +++ b/drivers/usb/storage/usual-tables.c
> @@ -34,17 +34,17 @@
>  		    vendorName, productName, useProtocol, useTransport, \
>  		    initFunction, flags) \
>  { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
> -  .driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
> +.driver_info = (flags)|(USB_US_TYPE_STOR<<24) }

That's dumb, and should not be changed, sorry.

checkpatch isn't always correct, please think when using it.

greg k-h

  reply	other threads:[~2012-05-18 19:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 19:18 Jeffrin Jose
2012-05-18 19:24 ` Greg KH [this message]
2012-05-19 13:48 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120518192445.GA4781@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ahiliation@yahoo.co.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome