From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: lrg@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] regulator: tps65910: add error message in case of failure
Date: Sat, 19 May 2012 19:48:18 +0100 [thread overview]
Message-ID: <20120519184818.GG4039@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1337438050-3707-6-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Sat, May 19, 2012 at 08:04:10PM +0530, Laxman Dewangan wrote:
> Prints error message whenever there is failure on allocating
> resource. Also used the dev_* to print messages instead of pr_*
This is fine but it depends on patch 2 so wouldn't apply. I generally
recommend putting this sort of cleanup earlier on in the series so that
it can be applied even if there's some problem with the more substantial
changes later on.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-19 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 14:34 [PATCH 0/5] regulator: tps65910: fixes/cleanups in dt supports Laxman Dewangan
2012-05-19 14:34 ` [PATCH 1/5] regulator: tps65910: use small letter for regulator names Laxman Dewangan
2012-05-19 17:19 ` Mark Brown
2012-05-19 14:34 ` [PATCH 2/5] regulator: tps65910: set of_node for regulator register config Laxman Dewangan
2012-05-19 17:48 ` Mark Brown
2012-05-19 18:19 ` Laxman Dewangan
2012-05-19 18:32 ` Mark Brown
2012-05-19 14:34 ` [PATCH 3/5] regulator: tps65910: use self device for regulator registration Laxman Dewangan
2012-05-19 18:01 ` Mark Brown
2012-05-19 14:34 ` [PATCH 4/5] regulator: tps65910: use devm_* for memory allocation Laxman Dewangan
2012-05-19 17:41 ` Mark Brown
2012-05-19 14:34 ` [PATCH 5/5] regulator: tps65910: add error message in case of failure Laxman Dewangan
2012-05-19 18:48 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519184818.GG4039@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome