From: Andreas Mohr <andi@lisas.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Lin Ming <ming.m.lin@intel.com>
Subject: Re: [PATCH 1/2] ACPI / PM: Fix error messages in drivers/acpi/bus.c
Date: Sun, 20 May 2012 12:01:38 +0200 [thread overview]
Message-ID: <20120520100138.GA20179@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <201205182300.23142.rjw@sisk.pl>
Hi,
> --- linux.orig/drivers/acpi/bus.c
> +++ linux/drivers/acpi/bus.c
> @@ -182,6 +182,24 @@ EXPORT_SYMBOL(acpi_bus_get_private_data)
> Power Management
> -------------------------------------------------------------------------- */
>
> +static char *state_string(int state)
> +{
> + switch (state) {
> + case ACPI_STATE_D0:
> + return "D0";
> + case ACPI_STATE_D1:
> + return "D1";
"const char", please?
In general: nice work, thanks!
Andreas Mohr
next prev parent reply other threads:[~2012-05-20 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 20:53 [PATCH] ACPI / PM: Fix error message in __acpi_bus_set_power() Rafael J. Wysocki
2012-05-18 20:56 ` Rafael J. Wysocki
2012-05-18 20:58 ` [PATCH 0/2] ACPI / PM: Fixes related to new definitions of device power states Rafael J. Wysocki
2012-05-18 21:00 ` [PATCH 1/2] ACPI / PM: Fix error messages in drivers/acpi/bus.c Rafael J. Wysocki
2012-05-20 10:01 ` Andreas Mohr [this message]
2012-05-20 12:10 ` Rafael J. Wysocki
2012-05-18 21:01 ` [PATCH 2/2] ACPI / PM: Make __acpi_bus_get_power() cover D3cold correctly Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520100138.GA20179@rhlx01.hs-esslingen.de \
--to=andi@lisas.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®