Re: [PATCH 3/5] perf tools: Split out util/symbol-elf.c

[Jiri Olsa <jolsa@redhat.com>]

hi,
this one needs rebase to current code, I got some conflicts

On Mon, May 14, 2012 at 04:10:22PM +0900, Namhyung Kim wrote:
> Factor out the dependency of ELF handling into separate
> symbol-elf.c file. It is a preparation of building a
> minimalistic version perf tools which doesn't depend on
> the elfutils.
> 
> Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
> ---
>  tools/perf/Makefile          |    1 +
>  tools/perf/util/symbol-elf.c |  691 +++++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/symbol.c     |  704 +-----------------------------------------
>  tools/perf/util/symbol.h     |   15 +
>  4 files changed, 715 insertions(+), 696 deletions(-)
>  create mode 100644 tools/perf/util/symbol-elf.c
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index e98e14c88532..7198c6cbc006 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -334,6 +334,7 @@ LIB_OBJS += $(OUTPUT)util/usage.o
>  LIB_OBJS += $(OUTPUT)util/wrapper.o
>  LIB_OBJS += $(OUTPUT)util/sigchain.o
>  LIB_OBJS += $(OUTPUT)util/symbol.o
> +LIB_OBJS += $(OUTPUT)util/symbol-elf.o

I think I'd like more generic elf interface compiled with either libelf
or our stuff.. also separated from "other perf related" symbol handling

looks like we need to be able to parse out build ID and symbols from
symtab or dyntab:

perf_elf__get_buildid(file, buf, len)

perf_elf__get_symbols(file, ..., callback, )
 - calling callback func for each symbol found,
   the call would then do the perf symbol related stuff

I understand that means much more changes.. so probably what you have now
is a good start and we can do that later.. just with above goal in mind

thanks,
jirka