mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Borislav Petkov <bp@amd64.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (v2)
Date: Thu, 24 May 2012 18:26:05 +0200	[thread overview]
Message-ID: <20120524162605.GK27063@aftab.osrc.amd.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC82923351ED712@SHSMSX101.ccr.corp.intel.com>

On Thu, May 24, 2012 at 04:15:02PM +0000, Liu, Jinsong wrote:
> The reason is, if we do so, it would be covered by native misc_register(&mce_chrdev_device) later when native kernel init (xen init first and then start native kernel).
> Under such case, if linux running under xen platform, /dev/mcelog point to vcpu, that's pointless since it cannot get any mcelog from physical cpu (which owned by xen).
> 
> Yes, we can use another misc device like /dev/xen-mcelog, w/ another device minor like 226, but that's not good for userspace mcelog tools. As far as I know, Novell mcelog use unified /dev/mcelog interface for linux running under either bare metal or xen platform.

Maybe create a symlink in /dev/mcelog pointing to /dev/xen-mcelog?

That should solve it.

> This patch just do redirection at xen code path, and that would not
> hurt anything to native kernel.

My concern is that if we remove /dev/mcelog one day, xen people will
cry.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

  reply	other threads:[~2012-05-24 16:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  5:45 Liu, Jinsong
2012-05-22  9:23 ` Borislav Petkov
2012-05-24 10:10   ` Liu, Jinsong
2012-05-24 10:30     ` Borislav Petkov
2012-05-24 16:15       ` Liu, Jinsong
2012-05-24 16:26         ` Borislav Petkov [this message]
2012-05-24 16:52           ` Liu, Jinsong
2012-05-24 19:10             ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-25 18:01               ` Liu, Jinsong
2012-05-25 18:03                 ` Konrad Rzeszutek Wilk
2012-05-25 19:55                   ` Liu, Jinsong
2012-05-25 20:23                     ` Konrad Rzeszutek Wilk
2012-05-25 20:47                       ` Liu, Jinsong
2012-05-25 21:15                         ` Konrad Rzeszutek Wilk
2012-05-24 18:49         ` Konrad Rzeszutek Wilk
2012-05-25 17:56           ` Liu, Jinsong
2012-05-25 18:01             ` Konrad Rzeszutek Wilk
2012-05-25 18:55               ` Liu, Jinsong
     [not found]               ` <DE8DF0795D48FD4CA783C40EC82923351F0D53@SHSMSX101.ccr.corp.intel.com>
2012-05-28 13:36                 ` Liu, Jinsong
2012-05-29 18:39                   ` Konrad Rzeszutek Wilk
2012-05-30 15:14                     ` Liu, Jinsong
2012-05-28 14:48                 ` [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (RFC) Liu, Jinsong
2012-05-29 13:38                   ` Borislav Petkov
2012-05-29 16:40                     ` Liu, Jinsong
2012-05-29 17:06                       ` Borislav Petkov
2012-05-30 14:40                         ` Liu, Jinsong
2012-05-30 15:09                     ` Liu, Jinsong
2012-05-30 15:08                       ` Konrad Rzeszutek Wilk
2012-05-30 15:20                         ` Liu, Jinsong
2012-05-30 15:29                           ` Borislav Petkov
2012-05-30 17:21                             ` Liu, Jinsong
2012-05-30 17:28                               ` Borislav Petkov
2012-05-31 13:00                             ` Liu, Jinsong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524162605.GK27063@aftab.osrc.amd.com \
    --to=bp@amd64.org \
    --cc=jinsong.liu@intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome