From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965074Ab2EYU1B (ORCPT ); Fri, 25 May 2012 16:27:01 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:52579 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933230Ab2EYU0q (ORCPT ); Fri, 25 May 2012 16:26:46 -0400 Date: Fri, 25 May 2012 16:26:42 -0400 (EDT) Message-Id: <20120525.162642.1462528409650391977.davem@davemloft.net> To: asharma@fb.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: compute a more reasonable default ip6_rt_max_size From: David Miller In-Reply-To: <1337976934-18065-1-git-send-email-asharma@fb.com> References: <1337976934-18065-1-git-send-email-asharma@fb.com> X-Mailer: Mew version 6.5 on Emacs 24.0.95 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Fri, 25 May 2012 13:26:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arun Sharma Date: Fri, 25 May 2012 13:15:34 -0700 > + /* Compute a reasonable default based on what we do for ipv4 > + * total size = 1/16th of total RAM > + * No more than 512k entries unless overridden on kernel cmdline */ Please format this comment correctly: /* Compute a reasonable default based on what we do for ipv4 * total size = 1/16th of total RAM * No more than 512k entries unless overridden on kernel cmdline */