From: David Miller <davem@davemloft.net>
To: devendra.aaru@gmail.com
Cc: florian@openwrt.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] r6040: Do a Proper deinit at errorpath and also when driver unloads (calling r6040_remove_one)
Date: Tue, 29 May 2012 22:31:39 -0400 (EDT) [thread overview]
Message-ID: <20120529.223139.1478035863626187036.davem@davemloft.net> (raw)
In-Reply-To: <1338335014-14877-1-git-send-email-devendra.aaru@gmail.com>
From: Devendra Naga <devendra.aaru@gmail.com>
Date: Wed, 30 May 2012 05:13:34 +0530
> so if mdiobus_alloc fails, the errorpath doesnt do a netif_napi_del and also
> doesn't set the priv data of the driver to NULL.
>
> at the driver unload stage the driver doesn't remove the NAPI context, and
> doesnt' set the priv data to NULL, and also doesn't call the pci_iounmap.
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Applied.
prev parent reply other threads:[~2012-05-30 2:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 23:43 Devendra Naga
2012-05-30 2:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529.223139.1478035863626187036.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devendra.aaru@gmail.com \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®