From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH repost] virtio-net: remove useless disable on freeze
Date: Wed, 30 May 2012 16:36:05 -0400 (EDT) [thread overview]
Message-ID: <20120530.163605.43003785250138845.davem@davemloft.net> (raw)
In-Reply-To: <20120530142128.GA31299@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 30 May 2012 17:21:29 +0300
> disable_cb is just an optimization: it
> can not guarantee that there are no callbacks.
> In particular it doesn't have any effect when
> event index is on.
>
> Instead, detach, napi disable and reset on freeze ensure we don't run
> concurrently with a callback.
>
> Remove the useless calls so we get same behaviour
> with and without event index.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Reposting a patch that seems to have fallen through cracks.
It seems to not make it to the lists and get properly picked up
by patchwork.
In any event, I've applied this, thanks.
prev parent reply other threads:[~2012-05-30 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 14:21 Michael S. Tsirkin
2012-05-30 20:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530.163605.43003785250138845.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®