On Thu, May 31, 2012 at 03:36:17PM +0900, jonghwa3.lee@samsung.com wrote: > On 2012년 05월 31일 02:26, Mark Brown wrote: > > On Tue, May 29, 2012 at 11:20:51AM +0900, Jonghwa Lee wrote: > >> +#ifdef CONFIG_COMMON_CLK > >> + struct clk clk32khz_ap; > >> + struct clk clk32khz_cp; > >> + struct clk clk32khz_pmic; > >> +#endif > > This should be a clock driver in drivers/clock. > Isn't it drivers/clk ? Could you explain more about this? It's using the drivers/clk API, yes - what I'm saying is that you should make a new MFD child driver drivers/clk/clk-max77686.c (or whatever) to contain this code.