mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Add Apple NLS
Date: Fri, 1 Jun 2012 14:57:41 -0700	[thread overview]
Message-ID: <20120601145741.c6289ea9.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAE9FiQVqPCRQbg8PShxbUeT5Z0gm88vm76QNT=btGCNRwGP2oA@mail.gmail.com>

On Fri, 1 Jun 2012 12:36:11 -0700
Yinghai Lu <yinghai@kernel.org> wrote:

> On Thu, May 17, 2012 at 9:36 PM, Vladimir '__-coder/phcoder' Serbinenko
> <phcoder@gmail.com> wrote:
> >> Also, I note that the unicode files have
> >>
> >> __ __ __ MODULE_LICENSE("Dual BSD/GPL");
> >>
> >> Where did this come from? __Is this a thing you decided upon or is it
> >> unicode.org's license requirement?
> >>
> 
> looks like Makefile change is not right... it has hard code =m for new modules.
> 
> those line should be removed.

Yup.  This?


From: Andrew Morton <akpm@linux-foundation.org>
Subject: fs/nls/Makefile: remove bogus CONFIG_ assignments

I assume these were debug things whcih snuck through.

Reported-by: Yinghai Lu <yinghai@kernel.org>
Cc: Vladimir Serbinenko <phcoder@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/nls/Makefile |   12 ------------
 1 file changed, 12 deletions(-)

diff -puN fs/nls/Makefile~fs-nls-makefile-remove-bogus-config_-assignemnts fs/nls/Makefile
--- a/fs/nls/Makefile~fs-nls-makefile-remove-bogus-config_-assignemnts
+++ a/fs/nls/Makefile
@@ -2,18 +2,6 @@
 # Makefile for native language support
 #
 
-CONFIG_NLS_MACCELTIC=m
-CONFIG_NLS_MACCENTEURO=m
-CONFIG_NLS_MACCROATIAN=m
-CONFIG_NLS_MACCYRILLIC=m
-CONFIG_NLS_MACGAELIC=m
-CONFIG_NLS_MACGREEK=m
-CONFIG_NLS_MACICELAND=m
-CONFIG_NLS_MACINUIT=m
-CONFIG_NLS_MACROMANIAN=m
-CONFIG_NLS_MACROMAN=m
-CONFIG_NLS_MACTURKISH=m
-
 obj-$(CONFIG_NLS)		+= nls_base.o
 
 obj-$(CONFIG_NLS_CODEPAGE_437)	+= nls_cp437.o
_


      reply	other threads:[~2012-06-01 21:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 13:59 Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-17 22:47 ` Andrew Morton
2012-05-18  4:36   ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-06-01 19:36     ` Yinghai Lu
2012-06-01 21:57       ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120601145741.c6289ea9.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phcoder@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome