From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <jaxboe@fusionio.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] block: fix return value on cfq_init() failure
Date: Mon, 4 Jun 2012 13:30:40 +0900 [thread overview]
Message-ID: <20120604043040.GA21357@google.com> (raw)
In-Reply-To: <20120601112954.GC3535@osiris.boeblingen.de.ibm.com>
cfq_init() would return zero after kmem cache creation failure. Fix
so that it returns -ENOMEM.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
block/cfq-iosched.c | 1 +
1 file changed, 1 insertion(+)
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -4202,6 +4202,7 @@ static int __init cfq_init(void)
if (ret)
return ret;
+ ret = -ENOMEM;
cfq_pool = KMEM_CACHE(cfq_queue, 0);
if (!cfq_pool)
goto err_pol_unreg;
next prev parent reply other threads:[~2012-06-04 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 11:29 WARNING: at block/blk-cgroup.c:867 Heiko Carstens
2012-06-04 4:30 ` Tejun Heo [this message]
2012-06-04 4:31 ` [PATCH 2/2] block: blkcg_policy_cfq shouldn't be used if !CONFIG_CFQ_GROUP_IOSCHED Tejun Heo
2012-06-04 13:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604043040.GA21357@google.com \
--to=tj@kernel.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome