mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
	Ian Abbott <ian.abbott@mev.co.uk>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	H Hartley Sweeten <hartleys@visionengravers.com>
Subject: Re: [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void __iomem *
Date: Mon, 4 Jun 2012 20:22:21 -0700	[thread overview]
Message-ID: <20120605032221.GA32598@kroah.com> (raw)
In-Reply-To: <4FBB6730.10802@mev.co.uk>

On Tue, May 22, 2012 at 11:15:12AM +0100, Ian Abbott wrote:
> On 2012-05-22 09:11, Dan Carpenter wrote:
> >On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote:
> >>@@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev,
> >>  	if (ret<  0)
> >>  		return ret;
> >>
> >>-	devpriv->ioaddr = (void *)(unsigned long)it->options[0];
> >>+	devpriv->ioaddr = (void __iomem *)(unsigned long)it->options[0];
> >
> >
> >Obviously, your patch is fine, but I was wondering if it was a
> >problem that it->options was only a 32 bit?  Seems like it would
> >deserve a comment.
> 
> Yes, it's a bit of a strange driver, this one.  It's a driver for a
> module sitting on a PCI card, but there is no driver I know of for
> the PCI card, and I've no idea what's actually ioremap'ing the
> memory!
> 
> Maybe we should quietly drop it and see if anyone complains?

I'm all for deleting code :)

Send me a patch removing it and I'll be glad to apply it.

thanks,

greg k-h

      reply	other threads:[~2012-06-05  6:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  1:10 H Hartley Sweeten
2012-05-22  8:11 ` Dan Carpenter
2012-05-22 10:15   ` Ian Abbott
2012-06-05  3:22     ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120605032221.GA32598@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=hartleys@visionengravers.com \
    --cc=ian.abbott@mev.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome