mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Butler <marc@plastictigers.com>
To: Sagar Dharia <sdharia@codeaurora.org>
Cc: davidb@codeaurora.org, bryanh@codeaurora.org,
	kheitke@codeaurora.org, gclemson@audience.com,
	broonie@opensource.wolfsonmicro.com,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, rob@landley.net,
	grant.likely@secretlab.ca, rob.herring@calxeda.com,
	ohad@wizery.com, gregkh@linuxfoundation.org,
	linus.walleij@linaro.org, rusty@rustcorp.com.au,
	joerg.roedel@amd.com, trenn@suse.de, ak@linux.intel.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] slimbus: Linux driver framework for SLIMbus.
Date: Tue, 5 Jun 2012 16:57:21 -0400	[thread overview]
Message-ID: <20120605205721.GA20560@plastictigers.com> (raw)
In-Reply-To: <1338340310-4473-1-git-send-email-sdharia@codeaurora.org>

The patch below fixes an bug where devices that have not be matched
to a driver will result in a segv when the bus is shutdown.

I am not sure what the policy on patches-on-patches is, it just
doesn't seem workable. So I this will be the first and last. Instead I
am maintaing a git repository that tracks Linus's tree:

git://git.plastictigers.com/slimbus.git

or it can be browsed via the web:

http://git.plastictigers.com/

Currently there are 3 branches:

slimbus-rfc-patch   : the original rfc patch (for reference)
slimbus-patch       : the current patch (as posted by Sagar)
slimbus-patch-fixes : slimbus-patch + fixes (like the one below)

There will likely be a couple of new branches in the future.

If anyone has a suggestion on a better way of doing this I am all
ears.

---
 drivers/slimbus/slimbus.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/slimbus/slimbus.c b/drivers/slimbus/slimbus.c
index 6d20241..673222c 100644
--- a/drivers/slimbus/slimbus.c
+++ b/drivers/slimbus/slimbus.c
@@ -125,6 +125,9 @@ static void slim_device_shutdown(struct device *dev)
 	struct slim_device *slim_dev;
 	struct slim_driver *driver;
 
+	if (!dev->driver)
+		return;
+
 	if (dev->type == &slim_dev_type)
 		slim_dev = to_slim_device(dev);
 	else
-- 
1.7.7


      parent reply	other threads:[~2012-06-05 20:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  1:11 Sagar Dharia
2012-05-30 18:13 ` Mark Brown
2012-06-04  9:54   ` Sagar Dharia
2012-06-01  0:16 ` Marc Butler
2012-06-04 10:21   ` Sagar Dharia
2012-06-04 10:27     ` Mark Brown
2012-06-04 10:36       ` Sagar Dharia
2012-06-04 10:42         ` Mark Brown
2012-06-04 17:13     ` Marc Butler
2012-06-06  8:13       ` Sagar Dharia
2012-06-03 16:34 ` Joe Perches
2012-06-04 10:25   ` Sagar Dharia
2012-06-04  3:14 ` Rob Landley
2012-06-04  7:29   ` Mark Brown
2012-06-04  9:51   ` Sagar Dharia
2012-06-04 23:41 ` Ryan Mallon
2012-06-06  8:19   ` Sagar Dharia
2012-06-05 20:57 ` Marc Butler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120605205721.GA20560@plastictigers.com \
    --to=marc@plastictigers.com \
    --cc=ak@linux.intel.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gclemson@audience.com \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=joerg.roedel@amd.com \
    --cc=kheitke@codeaurora.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=rusty@rustcorp.com.au \
    --cc=sdharia@codeaurora.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®