From: Sam Ravnborg <sam@ravnborg.org>
To: Robert Love <robert.w.love@intel.com>
Cc: linux-scsi@vger.kernel.org, baryluk@smp.if.uj.edu.pl,
linux-kernel@vger.kernel.org, JBottomley@parallels.com,
devel@open-fcoe.org, Mark Rustad <mark.d.rustad@intel.com>,
yi.zou@intel.com
Subject: Re: [PATCH] libfcoe: Fix section mismatch
Date: Wed, 6 Jun 2012 21:58:40 +0200 [thread overview]
Message-ID: <20120606195840.GA31186@merkur.ravnborg.org> (raw)
In-Reply-To: <20120606185948.26178.86781.stgit@fritz>
On Wed, Jun 06, 2012 at 11:59:48AM -0700, Robert Love wrote:
> From: Mark Rustad <mark.d.rustad@intel.com>
>
> Recent changes to add fcoe_sysfs caused libfcoe_init to call fcoe_transport_exit
> in a module initialization routine. The change resulted in the below error. This
> patch removes the __exit keyword from the fcoe_transport_exit definition such
> that it may be called from an __init routine.
>
> WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x21): Section mismatch in reference from the function init_module() to the function .exit.text:fcoe_transp
> exit()
> The function __init init_module() references
> a function __exit fcoe_transport_exit().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> fcoe_transport_exit() so it may be used outside an exit section.
>
> Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
> Signed-off-by: Robert Love <robert.w.love@intel.com>
Looks good.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
prev parent reply other threads:[~2012-06-06 19:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 16:15 WARNING: arch/x86/built-in.o: Section mismatch in reference from the variable test_nmi_ipi_callback_na to function .ini.text:test_nmi_ipi_callback Witold Baryluk
2012-06-04 14:36 ` Don Zickus
2012-06-04 14:59 ` H. Peter Anvin
2012-06-04 15:08 ` Don Zickus
2012-06-04 16:35 ` Sam Ravnborg
2012-06-04 19:08 ` Different WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x1a): Section mismatch in reference from the function init_module() to the function .exit.text:fcoe_transport_exit() Witold Baryluk
2012-06-04 19:17 ` Sam Ravnborg
2012-06-04 20:52 ` Zou, Yi
2012-06-04 22:33 ` Sam Ravnborg
2012-06-04 23:11 ` Zou, Yi
2012-06-06 18:59 ` [PATCH] libfcoe: Fix section mismatch Robert Love
2012-06-06 19:58 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606195840.GA31186@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=JBottomley@parallels.com \
--cc=baryluk@smp.if.uj.edu.pl \
--cc=devel@open-fcoe.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=robert.w.love@intel.com \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®