From: David Miller <davem@davemloft.net>
To: joe.jin@oracle.com
Cc: jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, gregory.v.rose@intel.com,
peter.p.waskiewicz.jr@intel.com, alexander.h.duyck@intel.com,
john.ronciak@intel.com, guru.anbalagane@oracle.com,
adnan.misherfi@oracle.com, e1000-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] e1000e: disable rxhash when try to enable jumbo frame also rxhash and rxcsum have enabled
Date: Thu, 07 Jun 2012 18:11:43 -0700 (PDT) [thread overview]
Message-ID: <20120607.181143.231727418873766540.davem@davemloft.net> (raw)
In-Reply-To: <4FD15020.7090709@oracle.com>
From: Joe Jin <joe.jin@oracle.com>
Date: Fri, 08 Jun 2012 09:06:40 +0800
> Upstream commit 70495a5 check if both rxhash and rxcsum enabled when enabling
> jumbo frames and disallowed all of them enabled at the same time.
>
> Since jumbo frame widely be used in real world, so when try to enable jumbo
> frames but rxhash and rxcsum have enabled, change the default behavior to
> disable receive hashing.
>
> Signed-off-by: Joe Jin <joe.jin@oracle.com>
> Signed-off-by: Guru Anbalagane <guru.anbalagane@oracle.com>
> Acked-by: Adnan Misherfi <adnan.misherfi@oracle.com>
If I were the Intel developers I would not apply this patch, it sets
a very bad precedence.
The tool tells you that the combination you're attempting to use is
invalid, and the kernel log message tells you exactly why.
The driver should never automatically change configuration settings
not actually requested by the user.
next prev parent reply other threads:[~2012-06-08 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 1:06 Joe Jin
2012-06-08 1:11 ` David Miller [this message]
2012-06-08 1:14 ` [E1000-devel] " Allan, Bruce W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607.181143.231727418873766540.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adnan.misherfi@oracle.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=guru.anbalagane@oracle.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joe.jin@oracle.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®