mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Zimmer <nzimmer@sgi.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Nathan Zimmer <nzimmer@sgi.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] watchdog: reduce "NMI watchdog enabled, takes one hw-pmu counter." messages
Date: Thu, 7 Jun 2012 12:14:34 -0500	[thread overview]
Message-ID: <20120607171433.GA21139@gulag1.americas.sgi.com> (raw)
In-Reply-To: <20120606211523.GF32472@redhat.com>

On Wed, Jun 06, 2012 at 05:15:23PM -0400, Don Zickus wrote:
> On Wed, Jun 06, 2012 at 01:09:46PM -0500, Nathan Zimmer wrote:
> >  watchdog: reduces some noise on a large system
> >  The printk buffer can be flooded with with redundant
> >  "NMI watchdog enabled, takes one hw-pmu counter." messages.
> >  It doesn't add any value beyond the first.
> > 
> >  Note the message needs logged a second time if the watchdog was disabled then
> >  reenabled.
> 
> Hi Nathan,
> 
> Thanks for the patch.  I added something similar to RHEL-6 a while ago
> that solved the same problem in a more robust way (I think).  IOW, I dealt
> with the watchdog failures too (for virt and bios issues).
> 
> It doesn't cover the nmi_disable case like your patch does, but is easy to
> add.
> 
> I attached it below.  Let me know if this meets your needs or not?
> 
> Cheers,
> Don

Yes it does seem to meet my needs quite well.

Thanks,
Nate 

      reply	other threads:[~2012-06-07 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 18:09 Nathan Zimmer
2012-06-06 21:15 ` Don Zickus
2012-06-07 17:14   ` Nathan Zimmer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120607171433.GA21139@gulag1.americas.sgi.com \
    --to=nzimmer@sgi.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®