mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Matt Carlson" <mcarlson@broadcom.com>
To: "ethan zhao" <ethan.kernel@gmail.com>
Cc: "Eric Dumazet" <eric.dumazet@gmail.com>,
	"Matt Carlson" <mcarlson@broadcom.com>,
	"Christian Kujau" <lists@nerdbynature.de>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: tg3: transmit timed out, resetting
Date: Thu, 7 Jun 2012 15:56:54 -0700	[thread overview]
Message-ID: <20120607225654.GA14247@mcarlson.broadcom.com> (raw)
In-Reply-To: <CABawtvOBJQ-oajFQmviOdgKCub-4n06kRW+x7nE2uyiWnoky9Q@mail.gmail.com>

On Wed, Jun 06, 2012 at 12:52:32PM +0800, ethan zhao wrote:
> Eric,
>   That is ask for confirmation from Matt Carlson of Broadcom.
> 
> Ethan
> 
> On Wed, Jun 6, 2012 at 12:12 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > On Wed, 2012-06-06 at 10:29 +0800, ethan zhao wrote:
> >> So no way to fix it via firmware update or Linux driver ? :<
> >
> > Yes, but you need to cooperate, or else it might take more time than
> > necessary.
> >
> > Asking questions like that on lkml is not going to help very much.
> >
> > So, once again, we kindly ask you try a recent kernel and post
> > register dump and some additional information when transmit timeouts
> > happen.
> >
> > The 'latest kernel' is either linux-3.5.rc1, or one of David Miller
> > tree :
> >
> > http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=summary
> >
> > or
> >
> > http://git.kernel.org/?p=linux/kernel/git/davem/net.git;a=summary
> >
> > Thanks

Does the following patch fix your problem?


[PATCH] tg3: Apply short DMA frag workaround to 5906

5906 devices also need the short DMA fragment workaround.  This patch
makes the necessary change.

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
---
 drivers/net/ethernet/broadcom/tg3.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index d55df32..2db4d70 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -14275,7 +14275,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
 		}
 	}
 
-	if (tg3_flag(tp, 5755_PLUS))
+	if (tg3_flag(tp, 5755_PLUS) ||
+	    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
 		tg3_flag_set(tp, SHORT_DMA_BUG);
 
 	if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
-- 
1.7.3.4



  reply	other threads:[~2012-06-07 22:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04 23:14 Christian Kujau
2012-06-05 16:57 ` Christian Kujau
2012-06-06  1:02 ` Matt Carlson
2012-06-06  1:58   ` ethan zhao
2012-06-06  2:14     ` Matt Carlson
2012-06-06  2:29       ` ethan zhao
2012-06-06  4:12         ` Eric Dumazet
2012-06-06  4:52           ` ethan zhao
2012-06-07 22:56             ` Matt Carlson [this message]
2012-06-08  1:24               ` Ethan Zhao
2012-06-11 23:42               ` David Miller
     [not found]                 ` <alpine.DEB.2.01.1206111650560.5568@trent.utfs.org>
2012-06-11 23:55                   ` David Miller
2012-06-06  6:17   ` Christian Kujau
2012-06-07  7:13     ` Christian Kujau
     [not found]       ` <CABawtvNSOkyphUmAU1EoCaCS-hGu-ejPHMmP=j-nRtBZfi7cwg@mail.gmail.com>
2012-06-07 12:52         ` Christian Kujau
2012-06-07 22:21           ` Christian Kujau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120607225654.GA14247@mcarlson.broadcom.com \
    --to=mcarlson@broadcom.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ethan.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@nerdbynature.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®