mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Jiri Slaby <jslaby@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] delete seven tty headers
Date: Fri, 8 Jun 2012 10:19:35 +0100	[thread overview]
Message-ID: <20120608101935.7b07b13d@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1339145808.25798.28.camel@x61.thuisdomein>

On Fri, 08 Jun 2012 10:56:48 +0200
Paul Bolle <pebolle@tiscali.nl> wrote:

> Commit 51c9d654c2def97827395a7fbfd0c6f865c26544 ("Staging: delete tty
> drivers") left seven headers unused: nothing in the tree includes them
> anymore. Two of those headers were still exported, but since nothing in
> the kernel actually uses the things those two headers provide, that
> seems pointless. Delete these seven tty headers too.
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Acked-by: Alan Cox <alan@linux.intel.com>

> 1) cdk.h, comstats.h, istallion.h, and stallion.h are still referenced
> in Documentation/ioctl/ioctl-number.txt and
> Documentation/magic-number.txt. Should those references be deleted too?

Probably - but the fact the ioctl numbers were used needs to remain to
avoid any bad reuses

Alan

  reply	other threads:[~2012-06-08  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08  8:56 Paul Bolle
2012-06-08  9:19 ` Alan Cox [this message]
2012-06-08 11:00 ` Jiri Slaby
2012-06-08 11:41   ` Paul Bolle
2012-06-08 14:03     ` Arnd Bergmann
2012-06-11 12:42       ` Jiri Slaby
2012-06-11 12:53         ` Alan Cox
2012-06-11 23:40           ` Greg Kroah-Hartman
2012-06-11 23:42             ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120608101935.7b07b13d@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®