From: Alexander Gordeev <agordeev@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [Fw: Re: [PATCH] x86, acpi/irq: Minor readability cleanup of gsi_to_irq()]
Date: Mon, 11 Jun 2012 09:44:34 +0200 [thread overview]
Message-ID: <20120611074434.GA3383@dhcp-26-207.brq.redhat.com> (raw)
Hi Ingo,
This patch probably get lost.
Should I repost?
----- Forwarded message from "Eric W. Biederman" <ebiederm@xmission.com> -----
Date: Fri, 30 Mar 2012 00:15:05 -0700
From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, acpi/irq: Minor readability cleanup of gsi_to_irq()
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
Alexander Gordeev <agordeev@redhat.com> writes:
> Init value of 'irq' variable is never used. So do not initialize it.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
Looks good to me. I was going to ask what idiot wrote that silly
thing but it appears that idiot was me. I must have rewritten
the function and forgotten to cleanup that initial assignment to irq.
That change makes it much clearer what is going on thank you.
Eric
> arch/x86/kernel/acpi/boot.c | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 406ed77..f148557 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -103,13 +103,11 @@ static u32 isa_irq_to_gsi[NR_IRQS_LEGACY] __read_mostly = {
>
> static unsigned int gsi_to_irq(unsigned int gsi)
> {
> - unsigned int irq = gsi + NR_IRQS_LEGACY;
> - unsigned int i;
> + unsigned int irq;
>
> - for (i = 0; i < NR_IRQS_LEGACY; i++) {
> - if (isa_irq_to_gsi[i] == gsi) {
> - return i;
> - }
> + for (irq = 0; irq < NR_IRQS_LEGACY; irq++) {
> + if (isa_irq_to_gsi[irq] == gsi)
> + return irq;
> }
>
> /* Provide an identity mapping of gsi == irq
----- End forwarded message -----
--
Regards,
Alexander Gordeev
agordeev@redhat.com
next reply other threads:[~2012-06-11 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 7:44 Alexander Gordeev [this message]
2012-06-11 8:37 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611074434.GA3383@dhcp-26-207.brq.redhat.com \
--to=agordeev@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®