mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: gma500: Cannot find any crtc or sizes - going 1024x768
Date: Tue, 12 Jun 2012 21:23:02 +0100	[thread overview]
Message-ID: <20120612212302.7a4ec41c@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAMeQTsbAxToYhP4T+PRsaTq-wrX4yCprM=jCfK8NRWi21Avzvw@mail.gmail.com>

> It matters because everything between 0x4100 - 0x4107 are Moorestown if you ask
> the macro, but are assigned to oaktrail_chip_ops. That makes Oaktrail ==
> Moorestown. IS_OAK might be a more appropriate name.

Oaktrail is sort of Moorestown, the divide is whether they have a PC like
set of I/O devices or not. It reflects the history of the driver


> IS_MRST is primarily used for two things:
> 1) Take LVDS enable fuse value into account

This like the non PC BIOS parsing should probably go. I've not taken it
out yet because I wanted to prove this. I'd be very surprised if it's the
right way to handle E600T but there's a bit of a lack of any public info
on that so who knows 8(.

> 2) Tell that LVDS must be on Pipe A

Which is true for Oaktrail and it seems E600T

> Those things where required for him to get the panel working,
> so why not include the 0x4108 in the IS_MRST check?

We probably want IS_GMA600() rather than IS_MRST.

Alan

  reply	other threads:[~2012-06-12 20:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11 14:16 Christian Gmeiner
2012-06-11 22:40 ` Patrik Jakobsson
2012-06-12  8:59   ` Christian Gmeiner
2012-06-12 11:06     ` Patrik Jakobsson
2012-06-12 11:15       ` Alan Cox
2012-06-12 11:37       ` Christian Gmeiner
2012-06-12 12:27         ` Alan Cox
2012-06-12 13:55           ` Patrik Jakobsson
2012-06-12 16:04             ` Alan Cox
2012-06-12 19:09               ` Patrik Jakobsson
2012-06-12 20:23                 ` Alan Cox [this message]
2012-06-12 21:58               ` Christian Gmeiner
2012-06-13  9:25                 ` Christian Gmeiner
2012-06-13 10:27                   ` Alan Cox
2012-06-13 10:31                 ` Alan Cox
2012-06-13 12:26                   ` Christian Gmeiner
2012-06-13 19:50                     ` Patrik Jakobsson
2012-06-21  8:55                       ` Christian Gmeiner
2012-06-21  8:54                     ` Christian Gmeiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120612212302.7a4ec41c@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=christian.gmeiner@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®