From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231Ab2FNHiD (ORCPT ); Thu, 14 Jun 2012 03:38:03 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56877 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122Ab2FNHiB (ORCPT ); Thu, 14 Jun 2012 03:38:01 -0400 Date: Thu, 14 Jun 2012 09:38:00 +0200 From: Michal Hocko To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, rientjes@google.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH -V9 08/15] hugetlb: Make some static variables global Message-ID: <20120614073800.GF27397@tiehlicka.suse.cz> References: <1339583254-895-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339583254-895-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1339583254-895-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 13-06-12 15:57:27, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > We will use them later in hugetlb_cgroup.c > > Signed-off-by: Aneesh Kumar K.V Reviewed-by: Michal Hocko Just a nit [...] > +extern int hugetlb_max_hstate; Maybe we can mark it __read_mostly as it is modified only during initialization and then it is just a constant. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic