From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit
Date: Thu, 14 Jun 2012 10:13:28 +0900 [thread overview]
Message-ID: <20120614101328.c23ab94b.yoshikawa.takuya@oss.ntt.co.jp> (raw)
In-Reply-To: <20120613213905.GD19290@amt.cnet>
On Wed, 13 Jun 2012 18:39:05 -0300
Marcelo Tosatti <mtosatti@redhat.com> wrote:
> > /* Return true if the spte is dropped. */
> > -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool *flush)
> > +static bool
> > +spte_write_protect(struct kvm *kvm, u64 *sptep, bool *flush, bool pt_protect)
> > {
> > u64 spte = *sptep;
> >
> > - if (!is_writable_pte(spte))
> > + if (!is_writable_pte(spte) &&
> > + !(pt_protect && spte_can_be_writable(spte)))
> > return false;
> >
> > rmap_printk("rmap_write_protect: spte %p %llx\n", sptep, *sptep);
> >
> > - *flush |= true;
> > if (is_large_pte(spte)) {
> > WARN_ON(page_header(__pa(sptep))->role.level ==
> > PT_PAGE_TABLE_LEVEL);
> > +
> > + *flush |= true;
> > drop_spte(kvm, sptep);
> > --kvm->stat.lpages;
> > return true;
> > }
> >
> > + if (pt_protect)
> > + spte &= ~SPTE_MMU_WRITEABLE;
> > spte = spte & ~PT_WRITABLE_MASK;
> > - mmu_spte_update(sptep, spte);
> > +
> > + *flush = mmu_spte_update(sptep, spte);
>
> This clears previous flush value when looping over multiple sptes in
> a single rmapp.
>
I'm sorry but I have to say that this function is hard to understand.
/* Return true if the spte is dropped. */
static bool
spte_write_protect(struct kvm *kvm, u64 *sptep, bool *flush, bool pt_protect)
Even with the comment above, can we guess what this function will do
for us without reading the body?
My feeling is that separate roles have been put into this one without
explaining each parameter.
I think there are two solutions:
1. separate this into a few functions
2. explain each parameter/role properly in the comment
Gaining a bit of lines by putting many things into one function will
not help us IMO.
Thanks,
Takuya
next prev parent reply other threads:[~2012-06-14 1:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 6:46 [PATCH v6 0/9] KVM: MMU: fast page fault Xiao Guangrong
2012-05-29 6:47 ` [PATCH v6 1/9] KVM: MMU: return bool in __rmap_write_protect Xiao Guangrong
2012-05-29 6:47 ` [PATCH v6 2/9] KVM: MMU: abstract spte write-protect Xiao Guangrong
2012-05-29 6:48 ` [PATCH v6 3/9] KVM: VMX: export PFEC.P bit on ept Xiao Guangrong
2012-05-29 6:48 ` [PATCH v6 4/9] KVM: MMU: fold tlb flush judgement into mmu_spte_update Xiao Guangrong
2012-05-29 6:49 ` [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit Xiao Guangrong
2012-06-11 23:32 ` Marcelo Tosatti
2012-06-12 2:23 ` Xiao Guangrong
2012-06-13 2:01 ` Marcelo Tosatti
2012-06-13 3:11 ` Xiao Guangrong
2012-06-13 21:39 ` Marcelo Tosatti
2012-06-14 1:13 ` Takuya Yoshikawa [this message]
2012-06-14 2:41 ` Xiao Guangrong
2012-06-14 2:36 ` Xiao Guangrong
2012-05-29 6:50 ` [PATCH v6 6/9] KVM: MMU: fast path of handling guest page fault Xiao Guangrong
2012-06-13 22:40 ` Marcelo Tosatti
2012-06-14 1:22 ` Takuya Yoshikawa
2012-06-18 19:21 ` Marcelo Tosatti
2012-06-19 2:07 ` Takuya Yoshikawa
2012-06-14 3:00 ` Xiao Guangrong
2012-06-18 19:32 ` Marcelo Tosatti
2012-06-19 2:04 ` Xiao Guangrong
2012-05-29 6:51 ` [PATCH v6 7/9] KVM: MMU: trace fast " Xiao Guangrong
2012-05-29 6:51 ` [PATCH v6 8/9] KVM: MMU: fix kvm_mmu_pagetable_walk tracepoint Xiao Guangrong
2012-05-29 6:52 ` [PATCH v6 9/9] KVM: MMU: document mmu-lock and fast page fault Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614101328.c23ab94b.yoshikawa.takuya@oss.ntt.co.jp \
--to=yoshikawa.takuya@oss.ntt.co.jp \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®