From: Felipe Balbi <balbi@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Felipe Balbi <balbi@ti.com>,
ben-linux@fluff.org, Tony Lindgren <tony@atomide.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
w.sang@pengutronix.de, linux-i2c@vger.kernel.org,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 09/17] i2c: omap: ack IRQ in parts
Date: Thu, 14 Jun 2012 14:47:14 +0300 [thread overview]
Message-ID: <20120614114712.GR13602@arwen.pp.htv.fi> (raw)
In-Reply-To: <20120614112017.GC31187@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
On Thu, Jun 14, 2012 at 12:20:17PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 14, 2012 at 01:20:42PM +0300, Felipe Balbi wrote:
> > According to flow diagrams on OMAP TRMs,
> > we should ACK the IRQ as they happen.
>
> You don't explain that you're adding a new dev_err() statement into the
> driver for a missing acknowledge.
>
> What if you're probing for a device - can this cause spam to the kernel
> console? What if you have protocol mangling enabled with the "ignore
> lack of ack bit set" ?
indeed... maybe dev_vdbg() would fit better, or just don't add anything.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-14 11:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 10:20 [PATCH 00/17] Big OMAP I2C Cleanup Felipe Balbi
2012-06-14 10:20 ` [PATCH 01/17] i2c: omap: simplify num_bytes handling Felipe Balbi
2012-06-14 10:33 ` Shilimkar, Santosh
2012-06-14 10:20 ` [PATCH 02/17] i2c: omap: decrease indentation level on data handling Felipe Balbi
2012-06-14 10:41 ` Shilimkar, Santosh
2012-06-14 10:40 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 03/17] i2c: omap: add blank lines Felipe Balbi
2012-06-14 10:43 ` Shilimkar, Santosh
2012-06-14 10:20 ` [PATCH 04/17] i2c: omap: simplify omap_i2c_ack_stat() Felipe Balbi
2012-06-14 10:45 ` Shilimkar, Santosh
2012-06-14 11:13 ` Russell King - ARM Linux
2012-06-14 11:45 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 05/17] i2c: omap: split out [XR]DR and [XR]RDY Felipe Balbi
2012-06-14 10:20 ` [PATCH 06/17] i2c: omap: improve 1p153 errata handling Felipe Balbi
2012-06-14 11:01 ` Shilimkar, Santosh
2012-06-14 11:17 ` Russell King - ARM Linux
2012-06-14 11:48 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 07/17] i2c: omap: re-factor receive/transmit data loop Felipe Balbi
2012-06-14 10:20 ` [PATCH 08/17] i2c: omap: switch over to do {} while loop Felipe Balbi
2012-06-14 11:03 ` Shilimkar, Santosh
2012-06-14 11:05 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 09/17] i2c: omap: ack IRQ in parts Felipe Balbi
2012-06-14 11:11 ` Shilimkar, Santosh
2012-06-14 11:46 ` Felipe Balbi
2012-06-14 11:20 ` Russell King - ARM Linux
2012-06-14 11:47 ` Felipe Balbi [this message]
2012-06-14 10:20 ` [PATCH 10/17] i2c: omap: get rid of the "complete" label Felipe Balbi
2012-06-14 10:20 ` [PATCH 11/17] i2c: omap: switch to devm_* API Felipe Balbi
2012-06-14 10:20 ` [PATCH 12/17] i2c: omap: switch to platform_get_irq() Felipe Balbi
2012-06-14 10:20 ` [PATCH 13/17] i2c: omap: bus: add a receiver flag Felipe Balbi
2012-06-14 10:20 ` [PATCH 14/17] i2c: omap: simplify errata check Felipe Balbi
2012-06-14 10:20 ` [PATCH 15/17] i2c: omap: always return IRQ_HANDLED Felipe Balbi
2012-06-14 11:18 ` Shilimkar, Santosh
2012-06-14 11:23 ` Russell King - ARM Linux
2012-06-14 11:25 ` Shilimkar, Santosh
2012-06-14 10:20 ` [PATCH 16/17] i2c: omap: simplify IRQ exit path Felipe Balbi
2012-06-14 10:20 ` [PATCH 17/17] i2c: omap: resize fifos before each message Felipe Balbi
2012-06-14 11:23 ` [PATCH 00/17] Big OMAP I2C Cleanup Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614114712.GR13602@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®