From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: mingo@kernel.org, pjt@google.com, venki@google.com,
efault@gmx.de, rostedt@goodmis.org, glommer@parallels.com
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [RFC][PATCH 3/4] sched/fair: clean up __clear_buddies_*
Date: Thu, 14 Jun 2012 15:29:05 +0200 [thread overview]
Message-ID: <20120614133212.750636820@chello.nl> (raw)
In-Reply-To: <20120614132902.800827488@chello.nl>
[-- Attachment #1: peter_zijlstra-sched-optimize_cgroup_pick_next_task_fair_3.patch --]
[-- Type: text/plain, Size: 1079 bytes --]
Slightly easier code flow, no functional changes.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched/fair.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1115,10 +1115,10 @@ static void __clear_buddies_last(struct
{
for_each_sched_entity(se) {
struct cfs_rq *cfs_rq = cfs_rq_of(se);
- if (cfs_rq->last == se)
- cfs_rq->last = NULL;
- else
+ if (cfs_rq->last != se)
break;
+
+ cfs_rq->last = NULL;
}
}
@@ -1126,10 +1126,10 @@ static void __clear_buddies_next(struct
{
for_each_sched_entity(se) {
struct cfs_rq *cfs_rq = cfs_rq_of(se);
- if (cfs_rq->next == se)
- cfs_rq->next = NULL;
- else
+ if (cfs_rq->next != se)
break;
+
+ cfs_rq->next = NULL;
}
}
@@ -1137,10 +1137,10 @@ static void __clear_buddies_skip(struct
{
for_each_sched_entity(se) {
struct cfs_rq *cfs_rq = cfs_rq_of(se);
- if (cfs_rq->skip == se)
- cfs_rq->skip = NULL;
- else
+ if (cfs_rq->skip != se)
break;
+
+ cfs_rq->skip = NULL;
}
}
next prev parent reply other threads:[~2012-06-14 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 13:29 [RFC][PATCH 0/4] sched: Optimize cgroup muck Peter Zijlstra
2012-06-14 13:29 ` [RFC][PATCH 1/4] sched/fair: track cgroup depth Peter Zijlstra
2012-06-14 13:29 ` [RFC][PATCH 2/4] sched: Push put_prev_task() into pick_next_task() Peter Zijlstra
2012-06-14 14:32 ` Steven Rostedt
2012-06-14 14:58 ` Peter Zijlstra
2012-06-15 9:49 ` Glauber Costa
2012-06-15 10:03 ` Peter Zijlstra
2012-06-15 10:01 ` Glauber Costa
2012-06-21 7:35 ` Michael Wang
2012-06-21 8:41 ` Peter Zijlstra
2012-06-21 9:23 ` Michael Wang
2012-06-14 13:29 ` Peter Zijlstra [this message]
2012-06-14 13:29 ` [RFC][PATCH 4/4] sched/fair: Optimize cgroup pick_next_task_fair Peter Zijlstra
2012-06-14 21:19 ` Peter Zijlstra
2012-06-15 14:03 ` Peter Zijlstra
2012-06-19 8:45 ` Paul Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614133212.750636820@chello.nl \
--to=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®