From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kamil Dudka <kdudka@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2o: avoid returning pointer to a local array in chtostr()
Date: Thu, 14 Jun 2012 15:05:25 +0100 [thread overview]
Message-ID: <20120614150525.5c0ed7f0@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1339678302-23770-1-git-send-email-kdudka@redhat.com>
On Thu, 14 Jun 2012 14:51:42 +0200
Kamil Dudka <kdudka@redhat.com> wrote:
> The pointer returned from chtostr() points to an array which is no longer valid
> when being used in the calling function. Although it may work, the behavior is
> undefined. Detected by cppcheck.
>
> Signed-off-by: Kamil Dudka <kdudka@redhat.com>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2012-06-14 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 12:51 Kamil Dudka
2012-06-14 14:05 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614150525.5c0ed7f0@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=kdudka@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®