From: Richard Cochran <richardcochran@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
John Stultz <johnstul@us.ibm.com>,
stable@vger.kernel.org, Sasha Levin <levinsasha928@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Jones <davej@redhat.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -stable] ntp: Correct TAI offset during leap second
Date: Mon, 18 Jun 2012 18:28:55 +0200 [thread overview]
Message-ID: <20120618162854.GA3111@netboy.at.omicron.at> (raw)
In-Reply-To: <1340027711.9372.29.camel@deadeye.wl.decadent.org.uk>
On Mon, Jun 18, 2012 at 02:55:11PM +0100, Ben Hutchings wrote:
> On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote:
> > The offset should change upon entering state OOP, so something like
> > the following (untested) patch should fix it for 3.2.9.
> [...]
>
> It looks like this patch just changes the offset reported by adjtimex()
> during an inserted second; is that right?
Right, nothing really terrible will happen. The worst that I can
imagine is that ntpd will set the new TAI offset during OOP, and then
the kernel will add one to it, resulting in the TAI offset being off
by one.
But I really doubt any software makes use of this information.
> Other than that, is 3.2.y likely to be OK? Is there a good way to test
> that in advance; does
> <http://codemonkey.org.uk/2012/06/15/testing-leap-code/> look
> reasonable?
Well, if you want to wait all night then that is one way to do it.
Here is a little test program I have been using:
https://github.com/richardcochran/leap
Thanks,
Richard
next prev parent reply other threads:[~2012-06-18 16:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 18:56 John Stultz
2012-06-15 19:01 ` John Stultz
2012-06-17 14:43 ` Ben Hutchings
2012-06-17 16:47 ` Jonathan Nieder
2012-06-17 17:34 ` Richard Cochran
2012-06-18 13:55 ` Ben Hutchings
2012-06-18 16:28 ` Richard Cochran [this message]
2012-06-19 11:54 ` Ben Hutchings
2012-06-19 17:26 ` John Stultz
2012-06-20 16:25 ` Richard Cochran
2012-06-20 16:42 ` John Stultz
2012-06-18 18:20 ` John Stultz
2012-06-19 11:57 ` Ben Hutchings
2012-07-01 1:28 ` Ben Hutchings
2012-07-01 5:27 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618162854.GA3111@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=ben@decadent.org.uk \
--cc=davej@redhat.com \
--cc=johnstul@us.ibm.com \
--cc=jrnieder@gmail.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®