From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: "Justin P. Mattock" <justinmattock@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging/rtl8182u: cleanup eprom_read function and clean all checkpatch warnings / errors
Date: Mon, 18 Jun 2012 17:02:18 -0700 [thread overview]
Message-ID: <20120619000218.GB4208@kroah.com> (raw)
In-Reply-To: <1339940911-20648-1-git-send-email-devendra.aaru@gmail.com>
On Sun, Jun 17, 2012 at 07:18:31PM +0530, Devendra Naga wrote:
> this patch cleans up the copying of the addr data into addr_str fields
> by using for loops.
>
> and also with the previous patch all the checkpatch warnings / errors are
> eliminated
Please only do one thing per patch, so break this up into a few
different ones.
thanks,
greg k-h
prev parent reply other threads:[~2012-06-19 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 13:48 Devendra Naga
2012-06-19 0:02 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619000218.GB4208@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome