mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: arizona: Add support for microphone supplies on Arizona devices
Date: Wed, 20 Jun 2012 12:48:40 +0100	[thread overview]
Message-ID: <20120620114840.GL3978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAF+7xWmmmUGy7zYdv+n66KVDUqLKJncjfGDosM7js17Mb2XSZg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

On Wed, Jun 20, 2012 at 07:32:18PM +0800, Axel Lin wrote:

> I think you may want to put this Kconfig entriy along with other
> Wolfson Microelectronics chips. So all Wolfson chips show in a group.

I'd rather keep the Kconfig entries sorted alphabetically.

> BTW, seems the MFD_ARIZONA patchs are not (yet) available in LKML.

Surprisingly I am aware of that...

> > +       if (selector < 0)
> > +               return -EINVAL;

> I think you don't need this checking. You already ensure min_uV >= 1700000.

No harm in being paranoid.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-06-20 11:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20 10:45 Mark Brown
2012-06-20 11:32 ` Axel Lin
2012-06-20 11:48   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620114840.GL3978@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=axel.lin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome