From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Ohad Ben-Cohen" <ohad@wizery.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"\"Sjur Brændeland\"" <sjur.brandeland@stericsson.com>
Subject: linux-next: manual merge of the remoteproc tree with Linus' tree
Date: Wed, 20 Jun 2012 16:31:30 +1000 [thread overview]
Message-ID: <20120620163130.b7bbb33fbed65837bf386f59@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]
Hi Ohad,
Today's linux-next merge of the remoteproc tree got conflicts in
drivers/remoteproc/remoteproc_core.c between commits e981f6d41acd
("remoteproc: fix print format warnings") and 30338cf09f82 ("remoteproc:
fix missing fault indication in error-path") from Linus' tree and commits
7826bf782364 ("remoteproc: Pass struct fw to load_segments and
find_rsc_table"), a933c9f8ef8a ("remoteproc: Add function
rproc_get_boot_addr") and 32d46fe7f468 ("remoteproc: Move Elf related
functions to separate file") from the remoteproc tree.
I fixed them up (see below) and can carry the fixes as necessary.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc drivers/remoteproc/remoteproc_core.c
index 66324ee,6779c2a..0000000
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@@ -1018,9 -789,7 +789,7 @@@ static int rproc_fw_boot(struct rproc *
if (ret)
return ret;
- ehdr = (struct elf32_hdr *)fw->data;
-
- dev_info(dev, "Booting fw image %s, size %d\n", name, fw->size);
+ dev_info(dev, "Booting fw image %s, size %zd\n", name, fw->size);
/*
* if enabling an IOMMU isn't relevant for this rproc, this is
@@@ -1032,19 -801,12 +801,14 @@@
return ret;
}
- /*
- * The ELF entry point is the rproc's boot addr (though this is not
- * a configurable property of all remote processors: some will always
- * boot at a specific hardcoded address).
- */
- rproc->bootaddr = ehdr->e_entry;
+ rproc->bootaddr = rproc_get_boot_addr(rproc, fw);
/* look for the resource table */
- table = rproc_find_rsc_table(rproc, fw->data, fw->size, &tablesz);
+ table = rproc_find_rsc_table(rproc, fw, &tablesz);
- if (!table)
+ if (!table) {
+ ret = -EINVAL;
goto clean_up;
+ }
/* handle fw resources which are required to boot rproc */
ret = rproc_handle_boot_rsc(rproc, table, tablesz);
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2012-06-20 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 6:31 Stephen Rothwell [this message]
2012-06-20 6:43 ` Ohad Ben-Cohen
2012-07-16 6:03 Stephen Rothwell
2012-07-16 6:12 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620163130.b7bbb33fbed65837bf386f59@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®