From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, alan@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next 2/4] mei: make mei_write_message more readable
Date: Wed, 20 Jun 2012 16:41:01 -0700 [thread overview]
Message-ID: <20120620234101.GA23638@kroah.com> (raw)
In-Reply-To: <1340086417-23090-2-git-send-email-tomas.winkler@intel.com>
On Tue, Jun 19, 2012 at 09:13:35AM +0300, Tomas Winkler wrote:
> 1. reduce hairy casting
> 2. replace open code with mei_count_empty_write_slots
> 4. include header size in check for overflow
> 3. use concise for loop instead of a while loop
>
> Change-Id: Idb7423bd7bc570a46437568908a0e8f6d7225555
What is that nonsense?
Ick.
I'll delete it this time, but please, never again...
next prev parent reply other threads:[~2012-06-20 23:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 6:13 [char-misc-next 1/4] mei: check for error codes that mei_flow_ctrl_creds retuns Tomas Winkler
2012-06-19 6:13 ` [char-misc-next 2/4] mei: make mei_write_message more readable Tomas Winkler
2012-06-20 23:41 ` Greg KH [this message]
2012-06-19 6:13 ` [char-misc-next 3/4] mei: mei_irq_thread_write_handler check for overflow Tomas Winkler
2012-06-19 6:13 ` [char-misc-next 4/4] mei: group wd_interface_reg with watchdog variables within struct mei_device Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620234101.GA23638@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome