From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Christopher Brannon <chris@the-brannons.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: keyboard.c: Remove locking from vt_get_leds.
Date: Fri, 22 Jun 2012 14:34:52 +0100 [thread overview]
Message-ID: <20120622143452.2e74c39d@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1340370994-6914-1-git-send-email-chris@the-brannons.com>
On Fri, 22 Jun 2012 08:16:34 -0500
Christopher Brannon <chris@the-brannons.com> wrote:
> There are three call sites for this function, and all three
> are called within a keyboard handler.
> kbd_event_lock is already held within keyboard handlers,
> so attempting to lock it in vt_get_leds causes deadlock.
>
> Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2012-06-22 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 13:16 Christopher Brannon
2012-06-22 13:34 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622143452.2e74c39d@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=chris@the-brannons.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®