mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>, <abbotti@mev.co.uk>,
	<fmhess@users.sourceforge.net>, <gregkh@linuxfoundation.org>
Subject: [PATCH 00/31] staging: comedi: ni_daq_700: cleanup the driver
Date: Fri, 22 Jun 2012 16:12:05 -0700	[thread overview]
Message-ID: <201206221612.05750.hartleys@visionengravers.com> (raw)

This is a full cleanup of the ni_daq_700 comedi driver.

This driver was originally based on the 8255 driver which exports
a subdevice interface used by other comedi drivers. This makes
the ni_daq_700 driver overly complex. Also, the exported symbols
in it are not referenced by any other code or declared in any
headers.

The pcmcia support code in this driver is also overly complex. All
the driver needs from the pcmcia support is for the device to be
enabled and to get the iobase address of the card. Everything else
appears to be cut-and-paste from other drivers.

H Hartley Sweeten (31):
  staging: comedi: ni_daq_700: remove exported symbols
  staging: comedi: ni_daq_700: move the MODULE_* stuff to the EOF
  staging: comedi: ni_daq_700: add the module_{init,exit} declarations
  staging: comedi: ni_daq_700: consolidate and init and exit functions
  staging: comedi: ni_daq_700: change driver registration order
  staging: comedi: ni_daq_700: cleanup to the pcmcia_driver declaration
  staging: comedi: ni_daq_700: remove some useless comments
  staging: comedi: ni_daq_700: refactor the pcmcia support code
  staging: comedi: ni_daq_700: Move the comedi_driver variable
  staging: comedi: ni_daq_700: Remove the unused private data struct
  staging: comedi: ni_daq_700: Remove a "do nothing" function stub
  staging: comedi: ni_daq_700: Remove unused variables from the
    boardinfo
  staging: comedi: ni_daq_700: Remove unneeded variables from the
    boardinfo
  staging: comedi: ni_daq_700: Remove bustype variable from the
    boardinfo
  staging: comedi: ni_daq_700: move the boardinfo variable
  staging: comedi: ni_daq_700: remove thisboard macro
  staging: comedi: ni_daq_700: remove unused private data variable
  staging: comedi: ni_daq_700: remove the CALLBACK_* code
  staging: comedi: ni_daq_700: remove a couple unused defines
  staging: comedi: ni_daq_700: remove the subdev_700_init function
  staging: comedi: ni_daq_700: remove the #ifdef'ed out irq code
  staging: comedi: ni_daq_700: change to 'attach' printk's to
    dev_printk's
  staging: comedi: ni_daq_700: remove local variable in the 'attach'
    function
  staging: comedi: ni_daq_700: remove some dangling ';'
  staging: comedi: ni_daq_700: use a local var to fix a > 80 char line
    issue
  staging: comedi: ni_daq_700: fix return for insn_config function
  staging: comedi: ni_daq_700: cleanup pcmcia debug output messages
  staging: comedi: ni_daq_700: remove unused pcmcia 'stop' logic
  staging: comedi: ni_daq_700: remove unneeded pcmcia private data
  staging: comedi: ni_daq_700: remove the pcmcia suspend/resume
  staging: comedi: ni_daq_700: refactor the pcmcia attach/detach

 drivers/staging/comedi/drivers/ni_daq_700.c | 508 +++++-----------------------
 1 file changed, 81 insertions(+), 427 deletions(-)

-- 
1.7.11


                 reply	other threads:[~2012-06-22 23:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206221612.05750.hartleys@visionengravers.com \
    --to=hartleys@visionengravers.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®