On Mon, Jun 25, 2012 at 04:48:21AM +0000, 함명주 wrote: > > + /* Microphone detection can't use idle mode */ > > + pm_runtime_get(info->dev); > Is it alright to use asynchronous get here? > (sync not required?) Yes, it's OK to do this - we're guaranteed that the device is already enabled at the time we decide to start the microphone detection (as we're in the middle of examining the state which needs a runtime reference). We're taking an additional reference here so that the device doesn't get powered off again after the event has been handled. > > + ret = arizona_request_irq(arizona, ARIZONA_IRQ_JD_RISE, > > + "JACKDET rise", arizona_jackdet, info); > Is this arizone_request_irq using threaded irq? (it's fine if so) Yes.