From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] avr32: Remove unused asm/numnodes.h
Date: Tue, 26 Jun 2012 09:32:55 +0200 [thread overview]
Message-ID: <20120626073255.GB7866@samfundet.no> (raw)
In-Reply-To: <1339174815.30984.8.camel@x61.thuisdomein>
Around Fri 08 Jun 2012 19:00:15 +0200 or thereabout, Paul Bolle wrote:
> This is handled with config options now.
>
Yes, but AVR32 doesn't have those bits in arch/avr32/Kconfig, hence removing
the NODES_SHIFT definition will reduce it to 0 in include/Linux/numa.h. I
suspect it is already done...
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Previous, inspirational, patch:
> 30957a8 ("[SPARC64]: Remove unused asm-sparc64/numnodes.h")
>
> 1) Tested basically like this:
> $ git grep -n "numnodes\.h"
> $ git grep -n "define[[:space:]]*NODES_SHIFT\b"
> arch/avr32/include/asm/numnodes.h:5:#define NODES_SHIFT 2
> include/linux/numa.h:6:#define NODES_SHIFT CONFIG_NODES_SHIFT
> include/linux/numa.h:8:#define NODES_SHIFT 0
> $
>
> arch/avr32/include/asm/numnodes.h | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
> delete mode 100644 arch/avr32/include/asm/numnodes.h
>
> diff --git a/arch/avr32/include/asm/numnodes.h b/arch/avr32/include/asm/numnodes.h
> deleted file mode 100644
> index 0b864d7..0000000
> --- a/arch/avr32/include/asm/numnodes.h
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -#ifndef __ASM_AVR32_NUMNODES_H
> -#define __ASM_AVR32_NUMNODES_H
> -
> -/* Max 4 nodes */
> -#define NODES_SHIFT 2
> -
> -#endif /* __ASM_AVR32_NUMNODES_H */
--
mvh
Hans-Christian Egtvedt
next prev parent reply other threads:[~2012-06-26 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 17:00 Paul Bolle
2012-06-26 7:32 ` Hans-Christian Egtvedt [this message]
2012-06-26 8:09 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626073255.GB7866@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®