mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Austin Boyle <Austin.Boyle@aviatnet.com>
Cc: rtc-linux@googlegroups.com,
	Joakim Tjernlund <Joakim.Tjernlund@transmode.se>,
	Alessandro Zummo <a.zummo@towertech.it>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: ds1307: Register offset moved to chip description
Date: Wed, 27 Jun 2012 15:33:32 +0200	[thread overview]
Message-ID: <20120627133332.GA21572@pengutronix.de> (raw)
In-Reply-To: <1340749442.3241.4046.camel@pc786-ubu.gnet.global.vpn>

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

On Wed, Jun 27, 2012 at 10:24:02AM +1200, Austin Boyle wrote:
> rtc: ds1307: Register offset moved to chip description
> 
> From: Austin Boyle <Austin.Boyle@aviatnet.com>
> 
> Register offset is added to chip description instead of being hard-coded
> into probe function.
> 
> Based on v3.5-rc4
> 
> Cc: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Signed-off-by: Austin Boyle <Austin.Boyle@aviatnet.com>

I would ack this patch immediately if it added another type using this
feature. But only changing already working code doesn't seem necessary
to me.

Regards,

    Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-06-27 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 22:24 Austin Boyle
2012-06-27 13:33 ` Wolfram Sang [this message]
2012-06-27 13:42 ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627133332.GA21572@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=Austin.Boyle@aviatnet.com \
    --cc=Joakim.Tjernlund@transmode.se \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®