mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Richard Purdie <rpurdie@rpsys.net>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Corentin Chary <corentin.chary@gmail.com>
Subject: Re: [PATCH] backlight: add support for disabling backlights via sysfs
Date: Thu, 28 Jun 2012 16:16:00 -0500	[thread overview]
Message-ID: <20120628211600.GB29456@thinkpad-t410> (raw)
In-Reply-To: <20120628193652.GB10945@srcf.ucam.org>

On Thu, Jun 28, 2012 at 08:36:52PM +0100, Matthew Garrett wrote:
> Userspace should already be prioritising platform interfaces over raw 
> interfaces, so if gmux works on the Mac then there's no problem. DMI 
> lists should, broadly speaking, be unnecessary - they're mostly a 
> symptom of us not understanding how the hardware is expected to work.

I agree that we want to avoid papering over problems instead of fixing
them, but we're already disabling the ACPI backlight in some cases and
will continue to do so for the time being. We're also doing it with
apple_bl. It's not a question of whether we do it, but how.

What I still don't understand is your reason for preferring
driver-specific interfaces for disabling backlights to a single generic
interface. Are you afraid that allowing it to be done from userspace
will make it too easy, and as a result quirks will be applied without
attempting to fix the problem (i.e. the quriking should go through a
kernel dev to ensure someone tries to fix the problem is made before
applying a quirk)?


  reply	other threads:[~2012-06-28 21:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 19:07 Seth Forshee
2012-06-28 19:10 ` Matthew Garrett
2012-06-28 19:30   ` Seth Forshee
2012-06-28 19:36     ` Matthew Garrett
2012-06-28 21:16       ` Seth Forshee [this message]
2012-06-28 21:19         ` Matthew Garrett
2012-06-29  2:43           ` joeyli
2012-06-29  2:57             ` Matthew Garrett
2012-06-29  7:18               ` joeyli
2012-06-29 12:24       ` Corentin Chary
2012-06-29 14:11         ` Seth Forshee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120628211600.GB29456@thinkpad-t410 \
    --to=seth.forshee@canonical.com \
    --cc=corentin.chary@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®