From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932639Ab2GCLPJ (ORCPT ); Tue, 3 Jul 2012 07:15:09 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:59288 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754256Ab2GCLPG (ORCPT ); Tue, 3 Jul 2012 07:15:06 -0400 Date: Tue, 3 Jul 2012 13:14:26 +0200 From: Thierry Reding To: Arnd Bergmann Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Sascha Hauer Subject: Re: linux-next: build failure after merge of the final tree (pwm tree related) Message-ID: <20120703111426.GA26468@avionic-0098.mockup.avionic-design.de> References: <20120629174826.546cc991459b12833f2aaebd@canb.auug.org.au> <201207030859.11975.arnd.bergmann@linaro.org> <20120703100049.GA8455@avionic-0098.mockup.avionic-design.de> <201207031106.42915.arnd.bergmann@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <201207031106.42915.arnd.bergmann@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:4mKjbgKvCTqNg8pJ2+0CuQZjm1jnQIUecOophqTGOtF bLZaKGnCYUVvyWIO73lxi2UDMKxPzOEa7qQ2xbxcmlYz8uRdyX Iz7UDXyKwE2BWdZZUgzmi5bRXSnCXp7E8mMPJsAiWpckQ35Q9f Rhy/1gOclkusFkEXuMlws/6Ccpoy4pqjlm08QIPoNG8NMEi/zF nBLxFpH0QQPvR6EycL+f+rfPfq6eJEXusUmhjPQ7YsfmWwMq/P Xr2ucQ8+uP22b4lEGYhq4UaCHLbmz6CqWM6SK/1gBmes7iJ5+s p0PO78M3hOwcwihglGBLi17P095YFtkNiKcfhHc+1htKcL3eNC lqDy5lzvFehqkRyhoI/aV6NBYSuUFOk3gEST7GlkszHaIK+PQW XNaljUHHLzYFJz3CKc6+48B61WhpIQVOdX75MKoT4pW5ZFYayh wtYmN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 03, 2012 at 11:06:42AM +0000, Arnd Bergmann wrote: > On Tuesday 03 July 2012, Thierry Reding wrote: > > Show Details > > On Tue, Jul 03, 2012 at 08:59:11AM +0000, Arnd Bergmann wrote: > > > On Tuesday 03 July 2012, Thierry Reding wrote: > > > > I came up with the attached patch. What do you think? It fixes the > > > > PowerPC allyesconfig issue for me. > > >=20 > > > This one looks correct, but I would still do it the other way around, > > > putting the depends statements into the locations of the other driver= s. > > > The main difference is that we can then independently convert the > > > remaining drivers, without having merge conflicts in the same line > > > every time we remove one of the dependencies. > >=20 > > The downside of that approach, however, is to make PWM override other > > settings. For instance if you have TWL6030_PWM selected and then decide > > to also select PWM, then the former will be automatically deselected to > > satisfy the dependency. I'm not sure if that's desired. >=20 > It's true that this may be confusing, but I think it's the right > approach for future multiplatform kernels. If we have e.g. a combined > omap+ux500+imx kernel, we can only have one implementation of the > PWM interfaces, and that should be the new one. It will certainly be an incentive to port other PWM implementations to the new framework. > It's less clear for the other architectures. Maybe a mixed approach > is better there, making CONFIG_PWM depend on !MACH_JZ4740 && > !PUV3_NB0916 && !BLACKFIN, but letting the remaining ARM versions > of the PWM code depend on !PWM. Yes, that would certainly be less confusing if somebody wants to build with e.g. JZ4740 support because Kconfig will then disable the new PWM instead of the other way around. Then again, maybe that's exactly the opposite of what we want. Also note that I already ported the blackfin PWM driver. Thierry --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJP8tQSAAoJEN0jrNd/PrOhGh8P/RUK2nTvwK7HOb1qr8q4gYKl 6+hPAKz9mMnvIH25J2Z7ALrCZjjCfsPPJd3EVTTs/8yhWWEMKAUxACgKKgxhmPL9 ZA6xVo5MtARyYQj6TFemW4aeRdIWFIMHtdz245AcxTO6xPnRxnsf5drUlrrhiL4/ RlDNI0Z7FV3HZrSkjRKd/MG0AfbvKVvCnN8QiDL0P3HfdPhAayixOJAFJKfikPed 7buUqXBZo4dQydyZrMPrGUjV1i6xUGnwZ4FZpZw/kYYVMeIQZ89iAeTtFnXsx57d O5ln+p7ZIQ7jwbnhkJ5fUoXDEzFK4pOYyvMRaJXJQiRpc3bA2dYpENedgi4V90bo g/hrnz250AnE+uOAdjlzuNSRHYlol4wgXDYdTppj8q6DFHAB7Lek7x64oGvKoytc R6+HQuhHPh85Y68lNP2TmJcEw+dppafVJ76oGYVYhbS9uWg9sEyl7FFBRFVX0s5p PuR7jKasgTNBoMWmFjD4ECMWK8xcfraYI633PUM7PzSDtfh89G0CQu1LiM1IN/Hz owJFOsQNX2gmdeZIsIZMG8KCMGjNUSi6kJtld0N+zIqlpXAGHz2l4yKpHySLNIJD D8GA3V09xm5jfOpBSgcr9rYWmxftNrlQXKIrq7SjRLo/H/GatsE8xYefN3L+eCu9 TDr4XYJxA3BI1kKSTi+K =nCDs -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--