From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755164Ab2GERWk (ORCPT ); Thu, 5 Jul 2012 13:22:40 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:36892 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135Ab2GERWi (ORCPT ); Thu, 5 Jul 2012 13:22:38 -0400 Date: Thu, 5 Jul 2012 10:22:30 -0700 From: Dmitry Torokhov To: Daniel Kurtz Cc: Henrik Rydberg , Joonyoung Shim , Nick Dyer , Yufeng Shen , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Olof Johansson , Benson Leung Subject: Re: [PATCH 04/23 v6] Input: atmel_mxt_ts - warn if sysfs could not be created Message-ID: <20120705172230.GB31383@core.coreip.homeip.net> References: <1340888904-15620-1-git-send-email-djkurtz@chromium.org> <1340888904-15620-5-git-send-email-djkurtz@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340888904-15620-5-git-send-email-djkurtz@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Henrik, On Thu, Jun 28, 2012 at 09:08:05PM +0800, Daniel Kurtz wrote: > If sysfs entry creation fails, the driver is still usable, so don't > just abort probe. Just warn and continue. > I understand that I am a bit late to the party :) but I do not agree with this change. Failure to create attributes is not sometihng that user could cause (at least not easily) and thus would not be a setup issue but something more severe. I believe we should fail loading the driver so sysfs attribute breakage will be noticed as soon as possible, instead of discovering it much much later in the process. So I think we should revert this one. Thanks. -- Dmitry