From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754741Ab2GIWZJ (ORCPT ); Mon, 9 Jul 2012 18:25:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:59824 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754610Ab2GIWZF (ORCPT ); Mon, 9 Jul 2012 18:25:05 -0400 Date: Mon, 09 Jul 2012 15:25:01 -0700 (PDT) Message-Id: <20120709.152501.1160923865998069512.davem@davemloft.net> To: Julia.Lawall@lip6.fr Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] drivers/net/ethernet/broadcom/cnic.c: remove invalid reference to list iterator variable From: David Miller In-Reply-To: <1341747464-1772-7-git-send-email-Julia.Lawall@lip6.fr> References: <1341747464-1772-1-git-send-email-Julia.Lawall@lip6.fr> <1341747464-1772-7-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: Mew version 6.5 on Emacs 24.0.97 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Date: Sun, 8 Jul 2012 13:37:43 +0200 > From: Julia Lawall > > If list_for_each_entry, etc complete a traversal of the list, the iterator > variable ends up pointing to an address at an offset from the list head, > and not a meaningful structure. Thus this value should not be used after > the end of the iterator. There does not seem to be a meaningful value to > provide to netdev_warn. Replace with pr_warn, since pr_err is used > elsewhere. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Applied.